Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move .devcontainer.json to .devcontainer folder #67

Conversation

jcbhmr
Copy link
Contributor

@jcbhmr jcbhmr commented Aug 18, 2023

why? generally this is where all the guides and info point to, so it makes sense for the template to put it in the most common spot. especially for a template. 🤷‍♂️

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! ✨

@samruddhikhandale samruddhikhandale merged commit f83dfb9 into devcontainers:main Aug 18, 2023
11 checks passed
@jcbhmr jcbhmr deleted the devcontainer-folder branch August 18, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants