Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a rule for removing artifacts by regex #118

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Added a rule for removing artifacts by regex #118

merged 3 commits into from
Oct 10, 2023

Conversation

Hardar3
Copy link
Contributor

@Hardar3 Hardar3 commented Sep 23, 2023 •
edited
Loading

Allows using DeleteByRegex for removing artifacts by redex
Resolves #111

@Hardar3 Hardar3 mentioned this pull request Sep 23, 2023
Closed
allburov
allburov reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@allburov allburov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Looks good, but I've added few comments how we can improve it

artifactory_cleanup/rules/delete.py Outdated Show resolved Hide resolved
artifactory_cleanup/rules/delete.py Outdated Show resolved Hide resolved
artifactory_cleanup/rules/delete.py Outdated Show resolved Hide resolved
artifactory_cleanup/rules/delete.py Show resolved Hide resolved
@Hardar3 Hardar3 changed the title Added a rule for removing artifacts by redex Added a rule for removing artifacts by regex Sep 30, 2023
@Hardar3
Copy link
Contributor Author

Hardar3 commented Sep 30, 2023

@allburov Hello! I fix your comments
Thank you for feedback

@allburov allburov merged commit ce0d854 into devopshq:master Oct 10, 2023
2 checks passed
@felipecrs
Copy link

Am I right that I can't combine DeleteOlderThan and DeleteByRegexpName to ensure I only delete artifacts that match both?

@allburov
Copy link
Member

why not?

@felipecrs
Copy link

It is not clear what is the different between Delete* rules and Include* rules. I suspected that the Delete* rules would always delete any artifacts that matches it, regardless of other Delete* rules. Unless they are filtered by Include* rules first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allburov allburov allburov left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to use Regex
3 participants
@Hardar3 @felipecrs @allburov