feat(output): save list of deleted artifacts as json #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allburov
reviewed
Jul 11, 2024
allburov
requested changes
Aug 15, 2024
There was a problem hiding this comment.
artifactory-cleanup --output=myfile.txt --output-format=json --output-artifacts
https://github.com/devopshq/artifactory-cleanup/pull/145/files#r1674212222
zkygr
force-pushed
the
feat/save_deleted_artifacts_as_json
branch
from
4fedd22
to
02b6f49
Compare
|
The fixup commit contains your required changes. |
zkygr
force-pushed
the
feat/save_deleted_artifacts_as_json
branch
from
a0b8487
to
ad796af
Compare
allburov
reviewed
Aug 19, 2024
Comment on lines
29
to
30
| output_format: str, | ||
| output_artifacts: bool, |
There was a problem hiding this comment.
Cleanup doesn't have to know about output, it works and returns in memory objects
Suggested change
| output_format: str, | |
| output_artifacts: bool, |
|
I hope it's latest pass and we can merge it 🤞 |
zkygr
force-pushed
the
feat/save_deleted_artifacts_as_json
branch
from
ee30a2b
to
ddcdada
Compare
|
The latest fixup contains:
|
zkygr
force-pushed
the
feat/save_deleted_artifacts_as_json
branch
from
ddcdada
to
8d4e2aa
Compare
allburov
reviewed
Aug 20, 2024
allburov
reviewed
Aug 20, 2024
|
TY! 🚀 |
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am also interested in the feature from Pull Request #136
I have rebased the feature branch on master, squashed the commits, and made some modifications.
@roytev introduced a new option,
--output-artifacts, which only worked with the specific combination of--output ... --output-format json --output-artifactsAs an alternative, I added a new
--output-formatnamedjson-with-artifact-list, which I find to be more understandable.