change default value of quote_parameters to True
#422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
changed the title
quote_parameters to Truequote_parameters to True
briantist
force-pushed
the
matrix-params/quoting-default
branch
from
d95b87e
to
21ab57d
Compare
allburov
approved these changes
Aug 7, 2023
briantist
force-pushed
the
matrix-params/quoting-default
branch
from
21ab57d
to
d5bb2e7
Compare
beliaev-maksim
approved these changes
Dec 14, 2023
|
@briantist thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to:
In #409, released in
v0.9.0, we added thequote_parametersoption to thedeploymethod and defaulted it toNone(to be later converted toFalse) to preserve existing behavior.We also added a warning when the value was
Noneso that we could warn that the default value would change toTrueinv0.10.0.This PR:
TrueNoneor a warning value, and to remove explicit setting where we aren't needing itTo be released in
v0.10.0If you would like to retain the ability to do a
v0.9.xpatch release, then this PR should not be merged yet, since we announced that this default would not change untilv0.10.0. So once any other PR that would force that version is merged, this could be merged too.I'm putting this up "early" so that I don't forget, and so the changes are ready when needed. Thanks!