ArtifactoryPath: override PurePath.__reduce__ to fix pickling #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pathlib.PurePath` instances can be reconstructed from only `self._parts`, so that is all that `PurePath.__reduce__` returns. This means that pickling an `ArtifactoryPath` objects strips out all other instance state including, crucially, `self.session` and the auth data it includes. This commit overrides `__reduce__` to include `self.__dict__` in the returned tuple, which is restored as instance state on unpickle per https://docs.python.org/3/library/pickle.html#object.__reduce__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathlib.PurePathinstances can be reconstructed from onlyself._parts, so that is all thatPurePath.__reduce__returns. This means that pickling anArtifactoryPathobjects strips out all other instance state including, crucially,self.sessionand the auth data it includes.This commit overrides
__reduce__to includeself.__dict__in the returned tuple, which is restored as instance state on unpickle per https://docs.python.org/3/library/pickle.html#object.__reduce__.