Short BitVector Optimizations (2) #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope I didn't mess anything up.
Fixed the masking for bit operations that was causing bits to appear outside the "official" BitVector bits for short BitVectors.
Previously, a resize which decreased the number of fields would not properly clear the values in the last field if the number of bits was not evenly divisible by 64. This bug persisted for long BitVectors.
added a section to check for overflow in a variety of cases and methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the bug has been fixed. Given that tests are still buggy on my machine, I'm putting my fate in the hands of Travis.