feat: wallet_call_with_max_cycles #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test? |
lwshang
approved these changes
Apr 9, 2024
wallet/src/lib.rs
Outdated
| @@ -949,11 +949,15 @@ mod wallet { | |||
| )] | |||
| async fn call_with_max_cycles(args: CallWithMaxCyclesArgs) -> Result<CallResult, String> { | |||
| let available_cycles = ic_cdk::api::canister_balance128(); | |||
| // If no margin is used then the call either fails locally with `Couldn't send message` or processing the response traps with `Canister out of cycles`. | |||
| // On the local network the margin needs to be ~1.7B cycles. (Experimentally determined in August 2024) | |||
There was a problem hiding this comment.
August 2024
Time travel ¯_(ツ)_/¯
.github/workflows/ci.yaml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| node-version: [12.x] | |||
| rust: ['1.70.0'] | |||
| rust: ['1.74.1'] | |||
There was a problem hiding this comment.
We can remove the rust: ['1.74.1'] and the following "Install Rust" step from workflow files.
GitHub Action runners default to have Rust. And rust-toolchain.toml will automatically take effect.
Therefore, we will only need the Rust version in rust-toolchain.toml which is more maintainable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the wallet is used to withdraw as many cycles as possible from a canister that will be deleted shortly, one wants to withdraw whatever is available. With this function it's no longer necessary to use heuristics to guesstimate how many cycles can be withdrawn.
Bumping the Rust version because