fix(ci): update to cargo-dist 0.5.0 and pin the version #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+51
to
+52
| # Publish jobs to run in CI | ||
| pr-run-mode = "skip" |
There was a problem hiding this comment.
What is the reason for changing pr-run-mode from the default?
"plan": run 'cargo dist plan' on PRs (recommended, also the default)
|
Closing in favor of #68 since it is a much simpler fix, and there are no tangible benefits to migrating to 0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on fork: https://github.com/smallstepman/dfx-extensions/pull/2
Changes:
release.ymlusingcargo dist generate-ciwhile preserving existing functionality (ability to executerelease.ymlfrom another workflowrelease-with-github.ymlCargo.tomland ine2e.yml