Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump ic-agent #4025

Merged
merged 2 commits into from
Dec 3, 2024
Merged

chore: Bump ic-agent #4025

merged 2 commits into from
Dec 3, 2024

Conversation

anchpop
Copy link
Contributor

@anchpop anchpop commented Dec 3, 2024

ic-agent 0.39 has come. This PR updates dfx to use it, from 0.38. There are a few breaking changes that I've corrected to the best of my ability. Please double check my work, since I am not an expert in ic-agent or the SDK

ic-agent changelog here: https://github.com/dfinity/agent-rs/blob/main/CHANGELOG.md#0390

The two breaking changes that affected us were:

  1. The lower-level update call functions now return the certificate in addition to the parsed response data.
  2. Make ingress_expiry required and set the default value to 3 min.

@anchpop anchpop force-pushed the @anchpop/bump-ic-agent branch from 197b730 to 8d52fd3 Compare December 3, 2024 16:52
@anchpop anchpop changed the title Bump ic-agent chore: Bump ic-agent Dec 3, 2024
@anchpop anchpop marked this pull request as ready for review December 3, 2024 19:31
@anchpop anchpop requested a review from a team as a code owner December 3, 2024 19:32
@ericswanson-dfinity ericswanson-dfinity enabled auto-merge (squash) December 3, 2024 20:07
@ericswanson-dfinity ericswanson-dfinity merged commit 2ec6162 into master Dec 3, 2024
296 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the @anchpop/bump-ic-agent branch December 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants