Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support counter-poise calculations in Python API #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Dec 1, 2024

Closes #122

@awvwgk awvwgk added the python related to the Python API label Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 77.16535% with 29 lines in your changes missing coverage. Please review.

Project coverage is 66.22%. Comparing base (3a50cbd) to head (36c3671).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
python/dftd3/interface.py 56.75% 16 Missing ⚠️
python/dftd3/library.py 86.25% 11 Missing ⚠️
src/dftd3/output.f90 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #128       +/-   ##
===========================================
+ Coverage   48.63%   66.22%   +17.58%     
===========================================
  Files          34       34               
  Lines        3707     4625      +918     
  Branches     1518     1589       +71     
===========================================
+ Hits         1803     3063     +1260     
+ Misses       1207      679      -528     
- Partials      697      883      +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awvwgk awvwgk added this to the v1.3.0 milestone Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python related to the Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Python API for counter-poise corrections
1 participant