Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: select a program indicator expression [DHIS2-15645] #179

Merged
merged 8 commits into from
Oct 23, 2023
Merged

feat: select a program indicator expression [DHIS2-15645] #179

merged 8 commits into from
Oct 23, 2023

Conversation

Sharmyn28
Copy link
Collaborator

@Sharmyn28 Sharmyn28 commented Oct 6, 2023 •
edited by jira bot
Loading

This PR has:

  • Program indicator selector and a text box that shows the PI expression, these components will allow user to select a TEI Header.
  • Expressions should be considered valid only if they have a TEA and/or functions
  • Show "description" expression, show names of TEA instead of ids

DHIS2-15645

Select a Program indicator
image

Show Program indicator expression
image

Valid and invalid Program indicators
image

No options: invalid Program Indicators
image

@dhis2-bot
Copy link

dhis2-bot commented Oct 6, 2023 •
edited
Loading

🚀 Deployed on https://pr-179--dhis2-android-settings.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 6, 2023 16:45 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 11, 2023 21:16 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 11, 2023 21:18 Inactive
@Sharmyn28 Sharmyn28 merged commit 9547363 into master Oct 23, 2023
6 checks passed
@Sharmyn28 Sharmyn28 deleted the DHIS2-15645 branch October 23, 2023 11:52
Sharmyn28 added a commit that referenced this pull request Oct 23, 2023
@Sharmyn28
feat: select a program indicator expression [DHIS2-15645] (#179)
2970343 
* feat: create section component
* feat: android expression validator
* feat: create program tei header component
* feat: handle change tei header
* feat: get expression description
* feat: save in datastore format
* feat: add tests to get expression description
Sharmyn28 added a commit that referenced this pull request Feb 6, 2024
@Sharmyn28
feat: select a program indicator expression [DHIS2-15645] (#179)
ef19493 
* feat: create section component
* feat: android expression validator
* feat: create program tei header component
* feat: handle change tei header
* feat: get expression description
* feat: save in datastore format
* feat: add tests to get expression description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sharmyn28 @dhis2-bot @simonadomnisoru