Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: /tracker/events exports notes with timestamps instead of dates DHIS2-18319 [2.39] #18951

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: /tracker/events exports notes with timestamps instead of dates DHIS2-18319 [2.39] #18951

merged 1 commit into from
Oct 30, 2024
+52 −17

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Oct 30, 2024 •
edited
Loading

Found the issue while working on #18943. It's already fixed on master.

Added assertion to existing test test. Example failure before the fix

[ERROR] Failures:
[ERROR]   EventExporterTest.shouldReturnEventsWithNotes:195->assertNotes:1267 note assertions (2 failures)
        org.opentest4j.MultipleFailuresError: note assertions DRKO4xUVrpr (2 failures)
        org.opentest4j.AssertionFailedError: created ==> expected: <2024-10-30T15:13:56.318> but was: <2024-10-30T00:00:00.000>
        org.opentest4j.AssertionFailedError: lastUpdated ==> expected: <Wed Oct 30 15:13:56 CET 2024> but was: <2024-10-30>
        org.opentest4j.MultipleFailuresError: note assertions SGuCABkhpgn (2 failures)
        org.opentest4j.AssertionFailedError: created ==> expected: <2024-10-30T15:13:56.318> but was: <2024-10-30T00:00:00.000>
        org.opentest4j.AssertionFailedError: lastUpdated ==> expected: <Wed Oct 30 15:13:56 CET 2024> but was: <2024-10-30>

@teleivo teleivo added the deploy Deploy DHIS2 instance with IM. label Oct 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@teleivo teleivo marked this pull request as ready for review October 30, 2024 14:27
@teleivo teleivo requested a review from a team October 30, 2024 14:27
@teleivo teleivo enabled auto-merge (squash) October 30, 2024 14:27
@teleivo teleivo changed the title fix: /tracker/events exports notes with dates instead of timestamps [2.39] fix: /tracker/events exports notes with timestamps instead of dates [2.39] Oct 30, 2024
@teleivo teleivo merged commit e20e3f9 into 2.39 Oct 30, 2024
11 of 12 checks passed
@teleivo teleivo deleted the DHIS2-18319-2.39 branch October 30, 2024 14:48
@teleivo teleivo changed the title fix: /tracker/events exports notes with timestamps instead of dates [2.39] fix: /tracker/events exports notes with timestamps instead of dates DHIS2-18319 [2.39] Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricocolasante enricocolasante enricocolasante approved these changes

Assignees
No one assigned
Labels
deploy Deploy DHIS2 instance with IM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teleivo @enricocolasante