Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix icons alignment #35

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

y-kitazawa0
Copy link
Contributor

@y-kitazawa0 y-kitazawa0 commented Feb 2, 2024

This is my fix for the following issue #34

・fix icon alignment
・make all icons in one line

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
weather-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 5:39am

Copy link
Owner

@dhruvabhat24 dhruvabhat24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20240202_112932
Only icons are arranged the respected details are not displaying

@dhruvabhat24 dhruvabhat24 added the help wanted Extra attention is needed label Feb 2, 2024
@y-kitazawa0
Copy link
Contributor Author

The details are displayed only after a research. This is the same behaviour as the current https://weather-app-lac-pi.vercel.app/ 🙏

Please take at the following, it's my fix for the icons alignment.

2024-02-03.0.08.50.mov

@dhruvabhat24 dhruvabhat24 merged commit e722da9 into dhruvabhat24:master Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants