-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reversing Dependency: Implementing Untyped-RPC on Top of Typed-RPC (draft) #51
Closed
Commits on Nov 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e04a2e2 - Browse repository at this point
Copy the full SHA e04a2e2View commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c6c8e5a - Browse repository at this point
Copy the full SHA c6c8e5aView commit details
Commits on Dec 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 65f0f7f - Browse repository at this point
Copy the full SHA 65f0f7fView commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7531988 - Browse repository at this point
Copy the full SHA 7531988View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f33fac - Browse repository at this point
Copy the full SHA 4f33facView commit details
Commits on Dec 13, 2023
-
improve support for ocaml-protoc (wip)
- Make use of ocaml-protoc's server implementation bundle as intended; - Adapt routeguide example to ocaml-protoc to show the differences. This results in a more complicated [Grpc.Rpc] interface that tries to better capture the common parts between ocaml-protoc and ocaml-protoc-plugin that can be used by ocaml-grpc.
Configuration menu - View commit details
-
Copy full SHA for 45d4878 - Browse repository at this point
Copy the full SHA 45d4878View commit details
Commits on Dec 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 042efeb - Browse repository at this point
Copy the full SHA 042efebView commit details -
Revert "add dedicated user facing libraries"
This reverts commit 042efeb.
Configuration menu - View commit details
-
Copy full SHA for 8677baa - Browse repository at this point
Copy the full SHA 8677baaView commit details -
enforce consistency of request and response modes
- This adds type safety to ensure the RPCs are called with the expected protocol (e.g. you cannot call a unary rpc with a server_streaming entry point, etc.). On the ocaml-protoc-plugin side, currently there are no markers for the rpc modes - this interface will permit adding them in the future without user facing changes. On the ocaml-protoc plugin, the value mode flows from the proto file definition and is checked in the user code as expected. Implementation note: There's perhaps a way to shorten the mapping of value-modes but I couldn't find one given that `Grpc` cannot depend on `Ocaml_protoc`, and thus the `Value_mode` types are not equal.
Configuration menu - View commit details
-
Copy full SHA for c0c4df5 - Browse repository at this point
Copy the full SHA c0c4df5View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 358e2c0 - Browse repository at this point
Copy the full SHA 358e2c0View commit details
Commits on Jan 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 225db75 - Browse repository at this point
Copy the full SHA 225db75View commit details -
fix the service names used by Typed_rpc
In the existing examples, the service name is separated from the package name by a dot, which I inadvertently omitted in the previous implementation. Note that as long as the service name used by a client and a server is the same, the right handler is executed, so there's some leeway in the actual choice of the convention to use. The hope is that the dot separated one is standard.
Configuration menu - View commit details
-
Copy full SHA for 67537c1 - Browse repository at this point
Copy the full SHA 67537c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcca2d3 - Browse repository at this point
Copy the full SHA dcca2d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7121496 - Browse repository at this point
Copy the full SHA 7121496View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b80a3a - Browse repository at this point
Copy the full SHA 9b80a3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9673317 - Browse repository at this point
Copy the full SHA 9673317View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.