Introduce Typed RPC Specification #53
Closed
+169
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mbarbin
force-pushed
the
typed-rpc-specification
branch
from
1908d45
to
ce02ee2
Compare
mbarbin
force-pushed
the
typed-rpc-specification
branch
from
ce02ee2
to
4d50f00
Compare
This is extracted from dialohq#48 as a standalone change which should allow starting building the other pieces (eio, lwt, async, protoc & protoc_plugin) independently.
mbarbin
force-pushed
the
typed-rpc-specification
branch
from
4d50f00
to
516fb61
Compare
|
ℹ️ This PR is intended to be closed, as its changes are likely to be subsumed by PR #56 and any subsequent related PRs. |
|
Hi @wokalski. I hope all is well! With arpaca around the corner, I thought it would be a reasonable time to close my stale PRs in this repo. Do you have objections to me going ahead and close them? Thanks a lot! |
|
sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new typed specification for RPCs, extracted from PR #48 as an independent change. This allows for the independent development of other components (eio, lwt, async, protoc & protoc_plugin).
Initial documentation has been added to the new interface as a starting point, which can be refined as we progress with the integration of other components.
The goal is to merge this PR first to facilitate the concurrent development of the remaining components.
opam-dune-lint#50 and Upgrade ocamlformat to version 0.26.1 #52 are merged