Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook template4 text dianna464 #157

Merged
merged 9 commits into from
Mar 21, 2023
Merged

Notebook template4 text dianna464 #157

merged 9 commits into from
Mar 21, 2023

Conversation

elboyran
Copy link
Contributor

@elboyran elboyran commented Mar 7, 2023

Should solve dianna-ai/dianna#464

@elboyran elboyran self-assigned this Mar 7, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@elboyran elboyran marked this pull request as ready for review March 21, 2023 14:19
@elboyran elboyran mentioned this pull request Mar 21, 2023
Closed
cwmeijer
cwmeijer approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Suggested 2 minor changes in the reviewnb, both times about elif:/else: if:. Great starting point like this!

@elboyran elboyran merged commit 0f38bc7 into main Mar 21, 2023
@elboyran elboyran deleted the NotebookTemplate4Text-dianna464 branch March 21, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

@geek-yang geek-yang Awaiting requested review from geek-yang

Assignees

@elboyran elboyran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elboyran @cwmeijer