Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tests for the 'tokenizer problem' #637

Merged
merged 1 commit into from
Sep 14, 2023
Merged

added tests for the 'tokenizer problem' #637

merged 1 commit into from
Sep 14, 2023

Conversation

WillemSpek
Copy link
Collaborator

@WillemSpek WillemSpek commented Sep 14, 2023 •
edited
Loading

Some added tests for the 'tokenizer problem' that I encountered during the work as discussed with @stefsmeets in issue #633 . I have marked the tests with mark.xfail as suggested by the guidelines here (end of the page).

@WillemSpek WillemSpek self-assigned this Sep 14, 2023
stefsmeets
stefsmeets approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I didn't know you could mark individual parameters like this 👍

@WillemSpek WillemSpek merged commit 7ed1f9c into main Sep 14, 2023
14 of 18 checks passed
@geek-yang geek-yang deleted the 633-tokenizer-tests branch October 26, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefsmeets stefsmeets stefsmeets approved these changes

Assignees

@WillemSpek WillemSpek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillemSpek @stefsmeets