Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Fixing the build on macOS #862

Closed
wants to merge 6 commits into from
Closed

[DRAFT] Fixing the build on macOS #862

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a22069f
Explicitly install numpy before installing rest of DIANNA in CI on macOS
loostrum Oct 3, 2024
0bb0486
Remove torch pinning from CI (related issue is closed)
loostrum Oct 3, 2024
f091422
Do not cache numpy install
loostrum Oct 3, 2024
04a2cd4
Fix numpy version getter
loostrum Oct 3, 2024
458d0df
Different approach: install wheel beforehand so numpy can hopefully b…
loostrum Oct 3, 2024
e9effe7
Re-add install of numpy
loostrum Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/actions/install-python-and-package/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,21 @@ runs:
python -m pip install --upgrade pip setuptools wheel

# only necessary on linux to avoid bloated installs
# pining the version of torch is temporary, see see #829
- name: Install tensorflow/pytorch cpu version
if: runner.os == 'Linux' && steps.cache-python-env.outputs.cache-hit != 'true'
shell: bash {0}
run: |
python -m pip install torch==2.3.1 --index-url https://download.pytorch.org/whl/cpu
python -m pip install --index-url https://download.pytorch.org/whl/cpu
python -m pip install tensorflow-cpu

# temporary: explicitly install wheel followed by numpy on macOS, see #861
- name: Install wheel and numpy
if: runner.os == 'macOS'
shell: bash {0}
run: |
python -m pip install wheel
python -m pip install "$(grep numpy setup.cfg | head -n 1)"

- name: Install DIANNA
shell: bash {0}
run: |
Expand Down
Loading