Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macos build GA issue related to spacy #864

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix macos build GA issue related to spacy #864

merged 2 commits into from
Oct 9, 2024

Conversation

SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Oct 9, 2024 •
edited
Loading

closes #861

see spacy release note https://github.com/explosion/spacy/releases

@SarahAlidoost SarahAlidoost changed the title [Draft] try to fix macos build GA Fix macos build GA issue related to spacy Oct 9, 2024
cwmeijer
cwmeijer approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks a lot! 🏆

@SarahAlidoost SarahAlidoost merged commit f3cda01 into main Oct 9, 2024
18 checks passed
@SarahAlidoost SarahAlidoost deleted the fix_macos_build branch October 9, 2024 14:04
@elboyran
Copy link
Contributor

Thanks, @SarahAlidoost !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

@loostrum loostrum Awaiting requested review from loostrum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix mac-os notebook and build fails
3 participants
@SarahAlidoost @elboyran @cwmeijer