Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CRC mismatch to be ignored #88

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Allow CRC mismatch to be ignored #88

merged 2 commits into from
Nov 15, 2024

Conversation

kevinherron
Copy link
Contributor

fixes #87

This allows a subclass the opportunity to ignore CRC mismatches or even implement an alternative verification algorithm if necessary.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

modbus/src/main/java/com/digitalpetri/modbus/client/ModbusRtuClient.java:234

  • The Javadoc comment is missing a period at the end. It should be 'Reset the transport's frame parser.'
 * Reset the transport's frame parser

modbus/src/main/java/com/digitalpetri/modbus/exceptions/ModbusCrcException.java:14

  • [nitpick] The error message 'CRC mismatch' could be more informative by including details about the expected and actual CRC values.
super("CRC mismatch");
@kevinherron kevinherron merged commit a978cb4 into master Nov 15, 2024
1 check passed
@kevinherron kevinherron deleted the issues/gh87 branch December 24, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow CRC mismatch to be ignored
1 participant