Skip to content

Commit

Permalink
Merge pull request #2615 from digma-ai/fix-linkage-error-in-otel-exte…
Browse files Browse the repository at this point in the history
…nsion

fix-linkage-error-in-otel-extension
  • Loading branch information
shalom938 authored Nov 28, 2024
2 parents 9adcdba + ba5b1f9 commit cfbe80c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ tasks {
//see org.digma.intellij.plugin.idea.execution.OtelAgentPathProvider
//don't forget to comment when done testing !
//"digma.agent.override.path" to "/home/shalom/workspace/digma/digma-agent/build/libs/digma-agent-2.0.4.jar"
//"digma.otel.extension.override.path" to "/home/shalom/workspace/digma/otel-java-instrumentation/agent-extension/build/libs/digma-otel-agent-extension-0.8.12.jar"
//"digma.otel.extension.override.path" to "/home/shalom/workspace/digma/otel-java-instrumentation/agent-extension/build/libs/digma-otel-agent-extension-2.10.1.jar"
//can also change the url from where the jar is downloaded when IDE starts
//"org.digma.otel.extensionUrl" to "some url
//"org.digma.otel.digmaAgentUrl" to "some url
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,13 @@ open class JavaToolOptionsBuilder(
javaToolOptions
.append("-javaagent:${otelAgentPathProvider.otelAgentPath}")
.append(" ")
.append("-Dotel.javaagent.extensions=${otelAgentPathProvider.digmaExtensionPath}")
.append(" ")

val useExtension: String? = System.getProperty("org.digma.plugin.useOtelExtension")
if (useExtension == null || useExtension == "true") {
javaToolOptions
.append("-Dotel.javaagent.extensions=${otelAgentPathProvider.digmaExtensionPath}")
.append(" ")
}

withDigmaAgentDebug()
withOtelTracesExporterOtlpEndpoint()
Expand Down
2 changes: 1 addition & 1 deletion jvm-common/src/main/resources/jars-urls.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
otel-agent=https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v2.10.0/opentelemetry-javaagent.jar
digma-extension=https://github.com/digma-ai/otel-java-instrumentation/releases/download/v2.10.0/digma-otel-agent-extension.jar
digma-extension=https://github.com/digma-ai/otel-java-instrumentation/releases/download/v2.10.1/digma-otel-agent-extension.jar
digma-agent=https://github.com/digma-ai/digma-agent/releases/download/v2.0.4/digma-agent.jar

0 comments on commit cfbe80c

Please sign in to comment.