Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping in regex and add tests #1131

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix escaping in regex and add tests #1131

merged 1 commit into from
Dec 17, 2024

Conversation

MartinRiese
Copy link
Contributor

@MartinRiese MartinRiese commented Dec 17, 2024

Summary

Fix regex issue found be automated scan. I doubt that code path has been used

https://dimagi.atlassian.net/browse/USH-5176

Feature Flag

None

Product Description

Safety Assurance

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • I have confidence that this PR will not introduce a regression for the reasons below

Automated test coverage

./test "updateInstanceQuery"

QA Plan

Safety story

I am pretty sure this code path has not been used in a while, since it is not working as expected. See first of the tests.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

@MartinRiese MartinRiese merged commit 19c244d into master Dec 17, 2024
5 checks passed
@MartinRiese MartinRiese deleted the riese/fix_regex branch December 17, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants