Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scrooling #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed scrooling #27

wants to merge 1 commit into from

Conversation

applm
Copy link

@applm applm commented Feb 18, 2013

requestLayout used to be called in every scroll step which is wrong and would probably cost you more than you get by view pooling. Corect behaviour is use computescrool to do all computation. This method is invoked automaticaly by invalidate

wrong and would probably cost you more than you get by view pooling.
@JiraiyaJunya
Copy link

why make the function "scrollTo" into comment?
// public void scrollTo(int x) {
// mScroller.startScroll(mNextX, 0, x - mNextX, 0);
// invalidate();
// }

@applm
Copy link
Author

applm commented Mar 4, 2013

Probably wasnt needed and its name is in conflict with Views method used to change scroll position. I guess you can uncoment it and change name if you need it.

@JiraiyaJunya
Copy link

thanks very much.Then how to use setSelection(int pos)?any ideas?

@applm
Copy link
Author

applm commented Apr 4, 2013

That is not implemented there i gues. If you want to implement it, you have
to store somewhere position of selected view and that call set selection
when it comes on screen and remove selection when it goes of screen

2013/4/4 JiraiyaJunya notifications@github.com

thanks very much.Then how to use setSelection(int pos)?any ideas?


Reply to this email directly or view it on GitHubhttps://github.com//pull/27#issuecomment-15877595
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants