This repository has been archived by the owner on Dec 24, 2021. It is now read-only.
Mention prefix option #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t display @mention as a usage
…ed extra checks, to build the regex, depending on the mentionPrefix value, and added a default prefix ! if both mentionPrefix is disabled and no prefix is set.
And we check for null in the constructor of the client.
|
@Gawdl3y I see no real problem with merging this, but it's up to you whether you want this or not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked out the repo, and saw in the Discord.js guide, that it's not possible, to disable the mention prefix.
So I decided to make it availabe to pass it as a setting, to the CommandoClient settings.
If accepted, someone else or me at another point, could work it out, to be guild based, and not only global.
But the option, to enable/disable is better than no option at all.
No open issue about this.