Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed URLRouter root_path handling. #1954

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fixed URLRouter root_path handling. #1954

merged 2 commits into from
Apr 3, 2024

Commits on Apr 3, 2024

  1. Add tests for handling root_path in URLRouting 

    Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
    @asedeno @carltongibson
    asedeno authored and carltongibson committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c84fd58 View commit details
    Browse the repository at this point in the history

  2. Handle root_path in URLRouter 

    If we have a scope["root_path"], raise if it does not prefix
scope["path"], and strip it from scope["path"] if it does. Do this
only if we're in an outermost URLRouter.

Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
    @asedeno @carltongibson
    asedeno authored and carltongibson committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b7032d7 View commit details
    Browse the repository at this point in the history