Change DataRepository2 references to DataRepository

[leewyatt]

Renamed all instances of DataRepository2 to DataRepository across the project. This change aligns with the recent updates in the jfxcentral-data project, where DataRepository2 was deprecated and renamed to DataRepository. This update ensures consistency with the latest project structure and removes references to the now-obsolete DataRepository2.

A subtle bug has been observed post-refactor, detailed as follows:

Replication Steps:

1. Delete existing .jfxcentralrepo cache file.
2. Run JFXCentral2App (develop).
3. Observe the data loading process and subsequent console error indicating a missing ...people/people.json file. (no such fiel).
4. A IndexOutOfBoundsException in QuickLinksGenerator's checkArrayList method because createShuffledSublist returns an empty list, contrary to expectations.

Possible Cause:

The bug seems related to the getRepositoryDirectory method in DataRepository (jfxcentral-data). The method’s behavior changes based on whether it is static or not:

Static: No bug triggered.
Non-static: Bug appears.

[FDelporte]

Looks good, to be retested with the change I just made regarding getRepositoryDirectory();