Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: SCA upgrade #122

Closed
wants to merge 19 commits into from
Closed

WIP: SCA upgrade #122

wants to merge 19 commits into from

Conversation

NorfairKing
Copy link

No description provided.

@dmjio
Copy link
Owner

dmjio commented Sep 6, 2019

@NorfairKing looks good, seems the FromJSON needs to be fleshed out.

@NorfairKing
Copy link
Author

@dmjio Yes, everything about this is not done. Is this really the only set of endpoints that needs to be finished?

@dmjio
Copy link
Owner

dmjio commented Sep 6, 2019

@NorfairKing seems like we need to facilitate this payment workflow

image

@dmjio
Copy link
Owner

dmjio commented Sep 6, 2019

We might also need SetupIntents

https://stripe.com/docs/api/setup_intents

@NorfairKing
Copy link
Author

We'll also need the new events then, because that's how you do the last part.

@emhoracek
Copy link
Contributor

My project also needs this functionality. Just let me know what I can help with!

@NorfairKing
Copy link
Author

@emhoracek It would be great if you could help finish the pull request because I don't have much time.

@emhoracek
Copy link
Contributor

@dmjio It looks like SetupIntents is only needed if you want to save cards for later without charging them, so that could be a separate PR.

Screen Shot 2019-09-10 at 12 06 39 PM

@NorfairKing
Copy link
Author

To anyone reading this: I have no unpushed local work, please help out because I don't really have the time to complete this.

@NorfairKing
Copy link
Author

@dmjio Could you have a look and tell me what else needs to be done for payment intents?

@NorfairKing NorfairKing changed the title WIP: payment intents api WIP: SCA upgrade Sep 30, 2019
@sigrlami
Copy link

sigrlami commented Nov 20, 2019

@NorfairKing what's the status of this? Did you manage to build PaymentIntent and related workflow successfully? Thanks

@NorfairKing
Copy link
Author

@sigrlami Yes, but I don't have the funds/time to finish this PR. I'm just using my own branch for the moment.

@dmjio dmjio mentioned this pull request Mar 4, 2020
@2piix
Copy link

2piix commented Jun 12, 2020

What's missing for this PR? I need Sessions support, and I have some free time to try this week.

@dmjio
Copy link
Owner

dmjio commented Jun 12, 2020

@NorfairKing

@NorfairKing
Copy link
Author

NorfairKing commented Jun 13, 2020

@2piix Go for it. I won't have the resources to finish this PR. I thought I did something on the topic of sessions in this PR though. Have a look.

, sessionClientReferenceId :: Maybe ClientReferenceId
, sessionCustomerEmail :: Maybe CustomerEmail
, sessionBillingAddressCollection :: Maybe TODO
, sessionDisplayItems :: Maybe [TODO]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NorfairKing Do you remember where you got sessionDisplayItems from? I can't see anything about display items in the API reference.

@emhoracek
Copy link
Contributor

Position Dev managed to take this branch and add a few more types and endpoints and get our client set up for SCA - thanks @NorfairKing for getting this started.

I'm going to try to finish the upgrade (currently still has a lot of TODO types for the stuff we didn't end up needing immediately) and contribute it back - I'll open a PR so you can see what we've added so far. It's a bit messy since we were trying to get it done by EOY.

@NorfairKing
Copy link
Author

Closing this.

@dmjio
Copy link
Owner

dmjio commented Dec 27, 2021

@NorfairKing
Copy link
Author

@NorfairKing should we deprecate in favor of https://github.com/Haskell-OpenAPI-Code-Generator/Stripe-Haskell-Library ?

I generate a custom stripe-client for every use-case, because that library takes ages to compile, with this: https://github.com/Haskell-OpenAPI-Code-Generator/Haskell-OpenAPI-Client-Code-Generator

I wouldn't necessarily say deprecate it, but this library is out-of-date for my use-case and I find it more sustainable to generate code instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants