Merge branch 'release/v0.4.1'

dmphillippo · Feb 4, 2022 · 8e6198e · 8e6198e
2 parents 5a33713 + d7a2ac8
commit 8e6198e
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: multinma
 Title: Bayesian Network Meta-Analysis of Individual and Aggregate Data
-Version: 0.4.0
+Version: 0.4.1
 Authors@R: 
     person(given = c("David", "M."),
            family = "Phillippo",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,9 @@
+# multinma 0.4.1
+
+* Fix: tidyr v1.2.0 breaks ordered multinomial models when some studies do not
+report all categories (i.e. some multinomial category outcomes are `NA` in
+`multi()`) (PR #11)
+
 # multinma 0.4.0
 
 * Feature: Node-splitting models for assessing inconsistency are now available

diff --git a/R/nma.R b/R/nma.R
@@ -1263,7 +1263,8 @@ nma.fit <- function(ipd_x, ipd_y,
                          }))
       agd_arm_ncat <- rowSums(agd_arm_cat > 0)
       # Replace missing category counts with 0 (these will drop out of the likelihood)
-      agd_arm_r <- tidyr::replace_na(agd_arm_y$.r, 0)
+      agd_arm_r <- agd_arm_y$.r
+      agd_arm_r[is.na(agd_arm_r)] <- 0
       agd_arm_n <- rowSums(agd_arm_y$.r, na.rm = TRUE)
     }
 

diff --git a/README.md b/README.md
@@ -72,7 +72,7 @@ paper:
 The `multinma` package can be cited as follows:
 
 > Phillippo, D. M. (2022). *multinma: Network Meta-Analysis of
-> Individual and Aggregate Data in Stan*. R package version 0.4.0, doi:
+> Individual and Aggregate Data in Stan*. R package version 0.4.1, doi:
 > [10.5281/zenodo.3904454](https://doi.org/10.5281/zenodo.3904454).
 
 When fitting ML-NMR models, please cite the methods paper:

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,6 +1,4 @@
-## Resubmission
-This is a resubmission. I have reduced the size of the package tarball to 2.5 MB
-(by compressing images in the vignettes).
+This update fixes a bug introduced with tidyr 1.2.0
 
 ## Test environments
 * local R installation (Windows 10), R 4.1.2