feat: support containerd subject annotations #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 69.58% 69.71% +0.13%
==========================================
Files 44 44
Lines 2528 2533 +5
==========================================
+ Hits 1759 1766 +7
+ Misses 477 476 -1
+ Partials 292 291 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrjoelkamp
force-pushed
the
feat-support-containerd-subject-annotations
branch
from
c1cef15
to
1e61417
Compare
mrjoelkamp
force-pushed
the
feat-support-containerd-subject-annotations
branch
from
1e61417
to
fd4e741
Compare
mrjoelkamp
force-pushed
the
feat-support-containerd-subject-annotations
branch
from
44c1356
to
0378c94
Compare
|
This LGTM, but I do wonder if we should really just have the name be a parameter that can be supplied to the verify operation if the input is an OCI layout. As the index.json isn't part of the image I don't know how much sense it makes to verify fields in there... Maybe something to consider if we ever need to add another annotation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: not sure where we stand on importing constants vs. hardcoding the strings, this imports but I can change it to just hardcode if we decided that way