Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only sign statements #179

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: only sign statements #179

merged 1 commit into from
Sep 26, 2024

Conversation

mrjoelkamp
Copy link
Contributor

@mrjoelkamp mrjoelkamp commented Sep 24, 2024

summary

  • SignStatements attempts to sign attestation manifests that were already signed
Signing attestations on image at docker://notary:server
Error: failed to sign attestation: failed to sign attestation layer failed to create signed layer: failed to get DSSE media type: unknown predicate type ""
  • only sign layers that have unsigned statements

@github-actions github-actions bot added the bug Something isn't working label Sep 24, 2024
@mrjoelkamp mrjoelkamp marked this pull request as ready for review September 24, 2024 20:02
@mrjoelkamp mrjoelkamp requested a review from a team as a code owner September 24, 2024 20:02
@mrjoelkamp
Copy link
Contributor Author

this seems to have unexpectedly broke a bunch of test cases 🤯 🤔

Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test covering this?

attestation/attestation.go Show resolved Hide resolved
sign.go Show resolved Hide resolved
@docker docker deleted a comment from codecov bot Sep 24, 2024
@mrjoelkamp mrjoelkamp merged commit 2a4bef0 into main Sep 26, 2024
9 checks passed
@mrjoelkamp mrjoelkamp deleted the fix-sign-unsigned-statements branch September 26, 2024 15:02
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.98%. Comparing base (203577e) to head (bb0843c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
sign.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   69.95%   69.98%   +0.02%     
==========================================
  Files          44       44              
  Lines        2533     2535       +2     
==========================================
+ Hits         1772     1774       +2     
  Misses        469      469              
  Partials      292      292              
Flag Coverage Δ
unittests 69.98% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants