-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only sign statements #179
Conversation
363e062
to
0425e5f
Compare
this seems to have unexpectedly broke a bunch of test cases 🤯 🤔 |
0425e5f
to
bb0843c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a test covering this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 69.95% 69.98% +0.02%
==========================================
Files 44 44
Lines 2533 2535 +2
==========================================
+ Hits 1772 1774 +2
Misses 469 469
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
summary
SignStatements
attempts to sign attestation manifests that were already signed