monitor: add common shell features to dev prompt #1289
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This makes the monitor mode from —invoke more user friendly by enabling features user might expect from dev shell. Interactive mode now has colors, history and keyboard control for movement (arrows, moving to beginning/end, by word, emacs controls etc). Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
SGTM, thank you! |
There was a problem hiding this comment.
This would be super useful 🎉 The approach LGTM 😄
I like the splash of color in it - ideally we'd sync up with the buildkit colors in some way. Autocompletion would also be excellent to add at some point once we've stabilized what all the monitor mode commands would be.
| } | ||
|
|
||
| prompt.New(exec, completer, prompt.OptionHistory([]string{ | ||
| "reload", "rollback", "exit", "help", |
There was a problem hiding this comment.
This sets the history at the beginning? I think we probably should just leave this empty (maybe a future enhancement to save the history to ~/.buildx/monitor_history or similar?)
|
@tonistiigi what changes would be needed in go-prompt? Would it be feasible to try and take this for v0.11? |
|
see the changes in vendor 6e05092 |
|
Looking through go-prompt, the maintainer seems inactive, so it seems likely we'd probably have to fork if we need changes. |
https://github.com/erikgeiser/promptkit and https://github.com/charmbracelet/bubbletea looks to be reliable alternatives. |
This makes the monitor mode from —invoke more
user friendly by enabling features user might expect
from dev shell.
Interactive mode now has colors, history and keyboard
control for movement (arrows, moving to beginning/end,
by word, emacs controls etc).
Opening as draft. If this solution (and base library it uses) seems desirable then some updates are needed in
go-prompt(or fork) to make it more configurable (currently made changes in vendor).@ktock