Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagetools: use docker/cli formatting #1882

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

uhthomas
Copy link

Use the formatting packages provided by docker/cli to comply with the official formatting documentation.

https://docs.docker.com/config/formatting/

The use of the official formatting packages also fixes the format templating.

Fixes: #1175

@uhthomas
Copy link
Author

@thaJeztah, this isn't finished but I thought it would be good to create a draft PR for some early feedback. I was initially just going to fix the formatting directive, but thought it would be nicer to make use of github.com/docker/cli/cli/command/inspect and github.com/docker/cli/cli/command/formatter. Using the formatting package should result in a lot less duplicate code, and would be consistent with docker/cli.

What are your thoughts?

Use the formatting packages provided by docker/cli to comply with the official
formatting documentation.

https://docs.docker.com/config/formatting/

The use of the official formatting packages also fixes the format templating.

Fixes: docker#1175

Signed-off-by: Thomas Way <thomas@6f.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imagetools inspect --format ignores formatting unless json is used
1 participant