-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export command #12120
base: main
Are you sure you want to change the base?
Add export command #12120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. Please sign-off your commit
1dfa246
to
598a1dc
Compare
Thank u @ndeloof. |
not sure how you did, but better rebase on main branch, stash all your commit and amend with |
598a1dc
to
cb0b70a
Compare
Oh sorry, i solved this issue with a messy approach:) |
Is this good? |
cb0b70a
to
6d413d0
Compare
Still sign-off line missing in commit message. Maybe amend and add it manually ? |
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
6d413d0
to
ab4a8da
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do I have to do anything else? |
@jarqvi just need to fix issues reported by CI :) |
Signed-off-by: MohammadHasan Akbari <116190942+jarqvi@users.noreply.github.com>
@ndeloof done =) |
go.mod
Outdated
@@ -34,6 +34,7 @@ require ( | |||
github.com/opencontainers/go-digest v1.0.0 | |||
github.com/opencontainers/image-spec v1.1.0 | |||
github.com/otiai10/copy v1.14.0 | |||
github.com/pkg/errors v0.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use errors
and fmt.Errorf
instead of the deprecated package github.com/pkg/errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, done.
@glours
Signed-off-by: MohammadHasan Akbari <116190942+jarqvi@users.noreply.github.com>
What I did
I noticed that we have this command in the Docker CLI, but not in Docker Compose. So I thought of adding it to make it useful for others.