Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: fix repository-file names on CentOS #244

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 19, 2021

relates to #163
relates to docker/docker-ce-packaging#513

Names of these files changed a couple of times (lowercase/uppercase). And differ between CentOS 7 and CentOS 8:

On CentOS 7:

docker run --rm centos:7 ls -1 /etc/yum.repos.d/
CentOS-Base.repo
CentOS-CR.repo
CentOS-Debuginfo.repo
CentOS-Media.repo
CentOS-Sources.repo
CentOS-Vault.repo
CentOS-fasttrack.repo
CentOS-x86_64-kernel.repo

On CentOS 8, the files were renamed, and now have -Linux in their names:

docker run --rm centos:8 ls -1 /etc/yum.repos.d/
CentOS-Linux-AppStream.repo
CentOS-Linux-BaseOS.repo
CentOS-Linux-ContinuousRelease.repo
CentOS-Linux-Debuginfo.repo
CentOS-Linux-Devel.repo
CentOS-Linux-Extras.repo
CentOS-Linux-FastTrack.repo
CentOS-Linux-HighAvailability.repo
CentOS-Linux-Media.repo
CentOS-Linux-Plus.repo
CentOS-Linux-PowerTools.repo
CentOS-Linux-Sources.repo

Names of these files changed a couple of times (lowercase/uppercase). And differ
between CentOS 7 and CentOS 8:

On CentOS 7:

    docker run --rm centos:7 ls -1 /etc/yum.repos.d/
    CentOS-Base.repo
    CentOS-CR.repo
    CentOS-Debuginfo.repo
    CentOS-Media.repo
    CentOS-Sources.repo
    CentOS-Vault.repo
    CentOS-fasttrack.repo
    CentOS-x86_64-kernel.repo

On CentOS 8, the files were renamed, and now have `-Linux` in their names:

    docker run --rm centos:8 ls -1 /etc/yum.repos.d/
    CentOS-Linux-AppStream.repo
    CentOS-Linux-BaseOS.repo
    CentOS-Linux-ContinuousRelease.repo
    CentOS-Linux-Debuginfo.repo
    CentOS-Linux-Devel.repo
    CentOS-Linux-Extras.repo
    CentOS-Linux-FastTrack.repo
    CentOS-Linux-HighAvailability.repo
    CentOS-Linux-Media.repo
    CentOS-Linux-Plus.repo
    CentOS-Linux-PowerTools.repo
    CentOS-Linux-Sources.repo

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when packages get renamed :)

LGTM

@thaJeztah thaJeztah merged commit 1496019 into docker:master Jul 19, 2021
@thaJeztah thaJeztah deleted the fix_centos_repo_names branch July 19, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants