Skip to content

Commit

Permalink
added @template-implements to solve Psalm issues
Browse files Browse the repository at this point in the history
  • Loading branch information
driehle committed Oct 15, 2023
1 parent 7cc1cfc commit 697873b
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Options/DBALConfiguration.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

/**
* Configuration options for a DBAL Connection
*
* @template-implements AbstractOptions<mixed>
*/
class DBALConfiguration extends AbstractOptions

Check failure on line 14 in src/Options/DBALConfiguration.php

View workflow job for this annotation

GitHub Actions / Static Analysis / PHPStan (8.2)

Class DoctrineORMModule\Options\DBALConfiguration has @implements tag, but does not implement any interface.

Check failure on line 14 in src/Options/DBALConfiguration.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

InvalidDocblock

src/Options/DBALConfiguration.php:14:1: InvalidDocblock: @template-implements must include the name of an implemented class, got Laminas\Stdlib\AbstractOptions<mixed> (see https://psalm.dev/008)

Check failure on line 14 in src/Options/DBALConfiguration.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

MissingTemplateParam

src/Options/DBALConfiguration.php:14:7: MissingTemplateParam: DoctrineORMModule\Options\DBALConfiguration has missing template params when extending Laminas\Stdlib\AbstractOptions, expecting 1 (see https://psalm.dev/182)
{
Expand Down
2 changes: 2 additions & 0 deletions src/Options/DBALConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

/**
* DBAL Connection options
*
* @template-implements AbstractOptions<mixed>
*/
final class DBALConnection extends AbstractOptions

Check failure on line 18 in src/Options/DBALConnection.php

View workflow job for this annotation

GitHub Actions / Static Analysis / PHPStan (8.2)

Class DoctrineORMModule\Options\DBALConnection has @implements tag, but does not implement any interface.

Check failure on line 18 in src/Options/DBALConnection.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

InvalidDocblock

src/Options/DBALConnection.php:18:1: InvalidDocblock: @template-implements must include the name of an implemented class, got Laminas\Stdlib\AbstractOptions<mixed> (see https://psalm.dev/008)

Check failure on line 18 in src/Options/DBALConnection.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

MissingTemplateParam

src/Options/DBALConnection.php:18:13: MissingTemplateParam: DoctrineORMModule\Options\DBALConnection has missing template params when extending Laminas\Stdlib\AbstractOptions, expecting 1 (see https://psalm.dev/182)
{
Expand Down
3 changes: 3 additions & 0 deletions src/Options/EntityManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

use Laminas\Stdlib\AbstractOptions;

/**
* @template-implements AbstractOptions<mixed>
*/
final class EntityManager extends AbstractOptions

Check failure on line 12 in src/Options/EntityManager.php

View workflow job for this annotation

GitHub Actions / Static Analysis / PHPStan (8.2)

Class DoctrineORMModule\Options\EntityManager has @implements tag, but does not implement any interface.

Check failure on line 12 in src/Options/EntityManager.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

InvalidDocblock

src/Options/EntityManager.php:12:1: InvalidDocblock: @template-implements must include the name of an implemented class, got Laminas\Stdlib\AbstractOptions<mixed> (see https://psalm.dev/008)

Check failure on line 12 in src/Options/EntityManager.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

MissingTemplateParam

src/Options/EntityManager.php:12:13: MissingTemplateParam: DoctrineORMModule\Options\EntityManager has missing template params when extending Laminas\Stdlib\AbstractOptions, expecting 1 (see https://psalm.dev/182)
{
/**
Expand Down
3 changes: 3 additions & 0 deletions src/Options/EntityResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
use function class_exists;
use function sprintf;

/**
* @template-implements AbstractOptions<mixed>
*/
final class EntityResolver extends AbstractOptions

Check failure on line 16 in src/Options/EntityResolver.php

View workflow job for this annotation

GitHub Actions / Static Analysis / PHPStan (8.2)

Class DoctrineORMModule\Options\EntityResolver has @implements tag, but does not implement any interface.

Check failure on line 16 in src/Options/EntityResolver.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

InvalidDocblock

src/Options/EntityResolver.php:16:1: InvalidDocblock: @template-implements must include the name of an implemented class, got Laminas\Stdlib\AbstractOptions<mixed> (see https://psalm.dev/008)

Check failure on line 16 in src/Options/EntityResolver.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

MissingTemplateParam

src/Options/EntityResolver.php:16:13: MissingTemplateParam: DoctrineORMModule\Options\EntityResolver has missing template params when extending Laminas\Stdlib\AbstractOptions, expecting 1 (see https://psalm.dev/182)
{
/**
Expand Down
2 changes: 2 additions & 0 deletions src/Options/SecondLevelCacheConfiguration.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

/**
* Configuration options for Second Level Cache
*
* @template-implements AbstractOptions<mixed>
*/
final class SecondLevelCacheConfiguration extends AbstractOptions

Check failure on line 14 in src/Options/SecondLevelCacheConfiguration.php

View workflow job for this annotation

GitHub Actions / Static Analysis / PHPStan (8.2)

Class DoctrineORMModule\Options\SecondLevelCacheConfiguration has @implements tag, but does not implement any interface.

Check failure on line 14 in src/Options/SecondLevelCacheConfiguration.php

View workflow job for this annotation

GitHub Actions / Static Analysis / Psalm (8.2)

InvalidDocblock

src/Options/SecondLevelCacheConfiguration.php:14:1: InvalidDocblock: @template-implements must include the name of an implemented class, got Laminas\Stdlib\AbstractOptions<mixed> (see https://psalm.dev/008)
{
Expand Down

0 comments on commit 697873b

Please sign in to comment.