refactor: better impl for sibling addition

dooit-org · Dec 6, 2024 · 78be1ea · 78be1ea
1 parent ce9d86c
commit 78be1ea
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/dooit/api/model.py b/dooit/api/model.py
@@ -125,20 +125,7 @@ def _add_sibling(self) -> Self:
         raise NotImplementedError  # pragma: no cover
 
     def add_sibling(self):
-        sibling = self._add_sibling()
-        index = self.order_index
-
-        cls = self.__class__
-        manager.session.query(cls).filter(cls.order_index > index).update(
-            {cls.order_index: cls.order_index + 1},
-            synchronize_session=False,
-        )
-
-        sibling.order_index = index + 1
-        manager.session.add(sibling)
-        manager.commit()
-
-        return sibling
+        return self._add_sibling()
 
     def shift_down(self) -> bool:
         """

diff --git a/dooit/api/todo.py b/dooit/api/todo.py
@@ -137,6 +137,7 @@ def _add_sibling(self) -> "Todo":
         todo = Todo(
             parent_todo=self.parent_todo,
             parent_workspace=self.parent_workspace,
+            order_index=self.order_index + 1,
         )
         todo.save()
         return todo

diff --git a/dooit/api/workspace.py b/dooit/api/workspace.py
@@ -105,6 +105,7 @@ def add_todo(self) -> "Todo":
     def _add_sibling(self) -> "Workspace":
         workspace = Workspace(
             parent_workspace=self.parent_workspace,
+            order_index=self.order_index + 1,
         )
         workspace.save()
         return workspace