Skip to content
This repository has been archived by the owner on Feb 6, 2021. It is now read-only.

remove regex semicolon to allow arrays in call dst_class #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mobsecteam
Copy link

Previously the semicolon before the arrow dictated that the dst_class had to be something that ended with a semicolon, however this is not always the case. You could have a case where an array is used with a primitive type, such as

invoke-virtual {v2}, [J->clone()Ljava/lang/Object;

To account for this, we can just remove the semicolon from the regex so that any dst_class before the -> can be parsed

Previously the semicolon before the arrow dictated that the dst_class had to be something that ended with a semicolon, however this is not always the case. You could have a case where an array is used with a primitive type, such as 

invoke-virtual {v2}, [J->clone()Ljava/lang/Object;

To account for this, we can just remove the semicolon from the regex so that any dst_class before the -> can be parsed
@dorneanu
Copy link
Owner

Hi,

thank your for your PR. Your "objection" seems legit. I'll have a look at some examples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants