Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional ProblemDetails default types and titles #58101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented Sep 26, 2024

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This PR adds additional problem details titles and types for HTTP statuses 407, 410, 411, 413, 414, 416, 417, 421, 501, and 505.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 26, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 26, 2024
Copy link
Contributor

Thanks for your PR, @joegoldman2. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@joegoldman2 joegoldman2 requested a review from a team as a code owner September 27, 2024 06:18
@martincostello martincostello added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Sep 27, 2024
@adityamandaleeka
Copy link
Member

Thanks @joegoldman2. This seems fine to me... @martincostello @captainsafia, do we have any policy for which statuses we include here?

@martincostello
Copy link
Member

Not that I'm aware of - I guess as long as it's an official code in the RFC it should be fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants