Descriptive Error for Improper Use of [AsParameters] #56114 #58218
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks for your PR, @smnsht. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
smnsht
requested review from
BrennanConroy,
halter73 and
captainsafia
as code owners
|
Converting draft to PR despite some failing tests in Interop.FunctionalTests. [QuarantinedTest("https://github.com//issues/41074")] Justification: Seems like those tests failed with no regard to my changes. Also, tests are failing for the main branch. |
|
FYI @captainsafia |
gfoidl
added
the
area-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptive Error for Improper Use of [AsParameters]
Description
Throw NotSupportedException if [AsParameters] is applied to an enumerable class.
Preserve existing behavior for collections that are also abstract classes, like IFormCollection. In order to do this, a dedicated unit test was added.
Fixes #56114 (in this specific format)