Skip to content

Commit

Permalink
Remove v1 links from the Home Page
Browse files Browse the repository at this point in the history
gh-572

The v1 flow is too brittle. It will be confusing having login be
meaningful for v1 and v2 simultaneously.

Any shortcomings of v2 do not outweigh the risk that v1 carries of
lockout.
  • Loading branch information
douglasnaphas committed Mar 26, 2024
1 parent 3646bce commit 91c5d64
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 79 deletions.
24 changes: 0 additions & 24 deletions .github/workflows/feature-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,30 +132,6 @@ jobs:
working-directory: content
run: |
npm run deploy
itest:
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
needs: [frontend, content]
steps:
- uses: actions/checkout@v4
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ vars.DEV_ROLE_ARN }}
aws-region: us-east-1
- name: Install itest
working-directory: itest
run: |
npm install
- name: Run smoke test (dev account)
working-directory: itest
env:
AWS_DEFAULT_REGION: "us-east-1"
AWS_REGION: "us-east-1"
run: |
npm run itest
itest-links-2023:
runs-on: ubuntu-latest
permissions:
Expand Down
39 changes: 0 additions & 39 deletions frontend/src/components/HomePage.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,45 +67,6 @@ class HomePage extends Component {
{createHaggadahLinkText}
</Button>
</div>
<div>
<br />
<Button
madliberationid="join-a-seder-button"
title="Join a seder"
variant="contained"
component={Link}
color="secondary"
to="/enter-room-code"
>
Join a seder
</Button>
</div>
<div>
<br />
<Button
madliberationid="lead-a-seder-in-person-button"
title="Lead a seder - in person"
variant="contained"
component={Link}
color="secondary"
to="/explain"
>
Lead a seder - in person
</Button>
</div>
<div>
<br />
<Button
madliberationid="lead-a-seder-by-video-button"
title="Lead a seder - by video"
variant="contained"
component={Link}
color="secondary"
to="/explain-video"
>
Lead a seder - by video
</Button>
</div>
<br />
{!user && (
<div id="login-container">
Expand Down
16 changes: 0 additions & 16 deletions frontend/src/components/HomePage.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,6 @@ describe("<HomePage />", () => {
const loginText = "Log in";
const logoutText = "Log out";

test("Should render buttons with the right links", () => {
const storage = { removeItem: jest.fn() };
render(
<MemoryRouter>
<HomePage storage={storage} />
</MemoryRouter>
);
const leadASederByVideoButton = screen
.getByText(leadASederByVideoText)
.closest("a");
expect(leadASederByVideoButton).toHaveTextContent(leadASederByVideoText);
expect(leadASederByVideoButton).toHaveAttribute("href", "/explain-video");
const joinASederButton = screen.getByText(joinASederText).closest("a");
expect(joinASederButton).toHaveTextContent(joinASederText);
expect(joinASederButton).toHaveAttribute("href", "/enter-room-code");
});
test("The Log In button should have an href to the login page", () => {
const storage = { removeItem: jest.fn() };
render(
Expand Down

0 comments on commit 91c5d64

Please sign in to comment.