Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fixpack plugin to sort package.json #28

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add fixpack plugin to sort package.json #28

wants to merge 6 commits into from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jun 12, 2022

Fixes #16

dsherret
dsherret requested changes Jul 1, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but a test for this would be useful in ./test/specs as well. (by the way, let me know if you would like me to do it)

@dsherret dsherret force-pushed the main branch 2 times, most recently from f995ecc to 7e2fe5a Compare July 2, 2022 00:20
@aminya
Copy link
Contributor Author

aminya commented Jul 3, 2022 •
edited
Loading

The plugin uses fs and path modules. Is it fine to bundle for Nodejs?

Edit: awaiting #27

@aminya
Copy link
Contributor Author

aminya commented Jul 21, 2022

The main function's stack is overflowed! Not sure what is causing this.

@tomdavidson tomdavidson mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: package.json sorter plugin
2 participants
@aminya @dsherret