Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weather.sh: Introduce fallback when wttr.in reaches call limit #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fvincenzo
Copy link
Contributor

When wttr.in reaches call limit returns the following:

Sorry, we are running out of queries to the weather service at the moment. Here is the weather report for the default city (just to show you what it looks like). We will get new queries as soon as possible.
You can follow https://twitter.com/igor_chubin for the updates.

Which makes weather.sh display a random error.

Make the error predictable.

When wttr.in reaches call limit returns the following:

Sorry, we are running out of queries to the weather service at the moment.
Here is the weather report for the default city (just to show you what it looks like).
We will get new queries as soon as possible.
You can follow https://twitter.com/igor_chubin for the updates.

Which makes weather.sh display a random error.

Make the error predictable.
@fvincenzo
Copy link
Contributor Author

fvincenzo commented Nov 1, 2024

Hello,

Is there anything else I should do to improve these patches?

Thanks!

@fvincenzo
Copy link
Contributor Author

Hello @ethancedwards8,

Unless you have something against it, in which case I am happy to address, could you please merge this patch?

Yesterday I saw again the error.

Thanks!

@fvincenzo
Copy link
Contributor Author

@ethancedwards8 @danerwilliams Any update on this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants