Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline date picker #951

Conversation

YoussefHenna
Copy link
Collaborator

@YoussefHenna YoussefHenna commented Oct 3, 2024

  • The regular date picker does not work in modals, this adds an inline mode for the picker to be able to show them in custom modals.
  • Does not render the input container, but instead renders the date picker directly.

Web
Screenshot from 2024-10-15 12-53-15

Android
Screenshot from 2024-10-16 13-17-11

Also works for ios, just no screenshot.


Important

Adds inline mode to DatePicker for rendering directly in modals using react-native-date-picker.

  • Behavior:
    • Adds inline prop to DatePicker in DatePicker.tsx to render date picker directly without input container.
    • Uses react-native-date-picker for inline mode in DatePickerComponent.tsx and DatePickerComponent.web.tsx.
    • Inline mode is supported on web, Android, and iOS.
  • Dependencies:
    • Adds react-native-date-picker to package.json.
  • Components:
    • Updates DatePickerComponent to use DateTimePicker for inline rendering.
    • Modifies DatePickerComponent.web.tsx to use variant="static" for inline mode.

This description was created by Ellipsis for ba31617. It will automatically update as commits are pushed.

Copy link

linear bot commented Oct 3, 2024

Copy link

github-actions bot commented Oct 3, 2024

Published version: @draftbit/ui@50.3.5-0b1e43.2

@YoussefHenna YoussefHenna marked this pull request as ready for review October 16, 2024 11:20
Copy link

Published version: @draftbit/ui@50.3.6-b32b49.2

@YoussefHenna YoussefHenna merged commit d8fa10e into master Oct 16, 2024
3 checks passed
@YoussefHenna YoussefHenna deleted the youssef/p-5457-ability-to-open-datepicker-when-its-inside-of-a-modal branch October 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants