Skip to content

Commit

Permalink
Use #site-navigation instead of #site-links so that siblings also
Browse files Browse the repository at this point in the history
get the updated outline.

Also remove the `list-group-item` outer selector.  Just make the focused
`.nav-link` have the elevated `z-index` so that the outline doesn't go
under the active link when the `.nav-link` before it is focused in the
siblings..
  • Loading branch information
drgrice1 committed Aug 10, 2023
1 parent f0288d9 commit 99a0b57
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
1 change: 0 additions & 1 deletion htdocs/themes/math4-yellow/_theme-overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,4 @@ a:not(.btn):focus {

:root {
--ww-site-nav-link-active-background-color: #{$primary};
--ww-site-nav-link-active-color: #{color-contrast($primary)};
}
4 changes: 0 additions & 4 deletions htdocs/themes/math4/bootstrap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,4 @@ a:not(.btn):focus {
outline-width: 1px;
}

#site-links a:not(.btn):focus {
outline-width: 2px;
}

@import "theme-overrides";
13 changes: 8 additions & 5 deletions htdocs/themes/math4/math4.scss
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ $site-nav-width: 250px !default;
}
}

a:not(.btn):focus {
outline-width: 2px;
}

.info-box {
border-radius: 0;
border: none;
Expand All @@ -219,11 +223,10 @@ $site-nav-width: 250px !default;

}
}
&.list-group-item {
.nav-link:focus {
position: relative;
z-index: 2;
}

.nav-link:focus {
position: relative;
z-index: 2;
}
}
}
Expand Down

0 comments on commit 99a0b57

Please sign in to comment.