Skip to content

Commit

Permalink
Add github_bot_name variable
Browse files Browse the repository at this point in the history
  • Loading branch information
davegaeddert committed Oct 4, 2018
1 parent 7f483ef commit 7dc95e3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ github_api_base_url = "https://github.yourcompany.com/api/v3"
github_app_id = "(GitHub App ID from the previous step)"
github_app_webhook_secret = "(webhook secret from the previous step)"
github_app_private_key = "(base64 encoded private key from the previous step -- ex. `cat private-key.pem | base64`)"
github_bot_name = "(slugified name of your GitHub App + [bot], ex. `pullapprove-enterprise[bot]`)"
```

## Download the PullApprove zip files
Expand Down
4 changes: 4 additions & 0 deletions aws/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ variable "github_app_webhook_secret" {
variable "github_app_private_key" {
description = "The base64 encoded private key"
}
variable "github_bot_name" {
default = "pullapprove[bot]"
description = "The slugified name of your GitHub App. Should end in `[bot]`."
}

# Only change these if testing/staging a new version or something
variable "github_status_context" {
Expand Down
1 change: 1 addition & 0 deletions aws/webhook.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ resource "aws_lambda_function" "pullapprove_webhook" {
GITHUB_APP_WEBHOOK_SECRET = "${var.github_app_webhook_secret}"
GITHUB_STATUS_CONTEXT = "${var.github_status_context}"
CONFIG_FILENAME = "${var.config_filename}"
GITHUB_BOT_NAME = "${var.github_bot_name}"
SENTRY_DSN = "${var.sentry_dsn}"
LOG_LEVEL = "${var.log_level}"
}
Expand Down

0 comments on commit 7dc95e3

Please sign in to comment.