Skip to content

Commit

Permalink
Per #2966, adjust the logic slightly to revert to existing behavior w…
Browse files Browse the repository at this point in the history
…here we only write the timing information of the input data to the gen_vx_mask output when no threshold was applied. This should reduce the number of diffs flagged by PR #3008
  • Loading branch information
JohnHalleyGotway committed Nov 6, 2024
1 parent 120d132 commit 0177be5
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions src/tools/other/gen_vx_mask/gen_vx_mask.cc
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,18 @@ int met_main(int argc, char *argv[]) {

// Combine the input data with the current binary mask
static DataPlane dp_out;
if(have_input_data &&
(mask_type == MaskType::Poly ||
mask_type == MaskType::Poly_XY ||
mask_type == MaskType::Shape ||
mask_type == MaskType::Box ||
mask_type == MaskType::Grid ||
thresh.get_type() != thresh_na)) {
dp_out = combine(dp_input, dp_mask, set_logic);
if(mask_type == MaskType::Poly ||
mask_type == MaskType::Poly_XY ||
mask_type == MaskType::Shape ||
mask_type == MaskType::Box ||
mask_type == MaskType::Grid ||
thresh.get_type() != thresh_na) {

// Combination logic based on presence of input data
SetLogic logic = (have_input_data ?
set_logic : SetLogic::None);

dp_out = combine(dp_input, dp_mask, logic);
}
// Otherwise, pass through the distance or raw values
else {
Expand Down

0 comments on commit 0177be5

Please sign in to comment.