-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2628 documentation updates #2817
Conversation
…A_obsOnly_WeatherRegime.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratosphereBias.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratosphereBias.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratosphereBias.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratosphereBias.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratosphereBias.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratospherePolar.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratospherePolar.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…fcstGFS_obsERA_StratospherePolar.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…sOnly_RMM.py Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committing requested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this @CPKalb. The information you added to these use cases is really beneficial. I will note that there is one failed case (see below for summary information) which is expected due to a file name change. I approve this PR.
Summary:
ERROR: Some differences were found
file not found (in truth but missing now)
A:/data/truth/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/plots/FV3_ERA_IBL_Freq_DJF.png
B:
file not found (in truth but missing now)
A:/data/truth/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/plots/FV3_ERA_IBL_Freq_DJF.pdf
B:
file not found (new output)
A:
B:/data/output/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/plots/GFS_ERA_IBL_Freq_DJF.pdf
file not found (new output)
A:
B:/data/output/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking/plots/GFS_ERA_IBL_Freq_DJF.png
Pull Request Testing
Describe testing already performed for these changes:
Tested that the documentation builds successfully and also read the documentation to check that they
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Read the documentation for the use cases that were updated and check that they use the new format and also check to see if there are typos or text that does not make sense. The use cases that were updated are:
s2s_mid_lat:
UserScript_fcstGFS_obsERA_Blocking
UserScript_obsERA_obsOnly_Blocking
UserScript_fcstGFS_obsERA_WeatherRegime
UserScript_obsERA_obsOnly_WeatherRegime
s2s_mjo:
UserScript_fcstGFS_obsERA_OMI
UserScript_obsERA_obsOnly_OMI
UserScript_obsERA_obsOnly_RMM
UserScript_obsERA_obsOnly_PhaseDiagram
s2s_stratosphere:
UserScript_fcstGFS_obsERA_StratosphereBias
UserScript_fcstGFS_obsERA_StratospherePolar
UserScript_fcstGFS_obsERA_StratosphereQBO
Link to the updated documentation: https://metplus.readthedocs.io/en/feature_2628_documentation_updates/generated/model_applications/index.html#subseasonal-to-seasonal-mid-latitude
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Yes
Do these changes include sufficient testing updates? [Yes or No]
??
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
No
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
No
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases