Merge pull request #7 from dubinc/add-default-path

Add default path to cookie
dubinc · May 13, 2024 · 62b2b3b · 62b2b3b
2 parents a082d6a + a375c26
commit 62b2b3b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/script/src/index.js b/packages/script/src/index.js
@@ -43,7 +43,7 @@
   // Utility function to set a cookie
   function setCookie(key, value, options) {
     // options: domain, expires, httpOnly, maxAge, path, sameSite, secure
-    document.cookie = `${key}=${value}; ${options.domain ? `domain=${options.domain}; ` : ''}${`expires=${new Date(options.expires || Date.now() + COOKIE_EXPIRES).toUTCString()}; `}${options.httpOnly ? 'httpOnly; ' : ''}${options.maxAge ? `max-age=${options.maxAge}; ` : ''}${options.path ? `path=${options.path}; ` : ''}${options.sameSite ? `sameSite=${options.sameSite}; ` : ''}${options.secure ? 'secure;' : ''}`;
+    document.cookie = `${key}=${value}; ${options.domain ? `domain=${options.domain}; ` : ''}${`expires=${new Date(options.expires || Date.now() + COOKIE_EXPIRES).toUTCString()}; `}${options.httpOnly ? 'httpOnly; ' : ''}${options.maxAge ? `max-age=${options.maxAge}; ` : ''}${`path=${options.path || '/'}`}${options.sameSite ? `sameSite=${options.sameSite}; ` : ''}${options.secure ? 'secure;' : ''}`;
   }
 
   // Function to check for {keys} in the URL and update cookie if necessary

diff --git a/packages/web/src/generic.ts b/packages/web/src/generic.ts
@@ -1,4 +1,4 @@
-import { version } from '../package.json';
+import { name, version } from '../package.json';
 import type { AnalyticsProps } from './types';
 import { getScriptSrc, isBrowser } from './utils';
 
@@ -15,6 +15,7 @@ function inject(props: AnalyticsProps): void {
   const script = document.createElement('script');
   script.src = src;
   script.defer = true;
+  script.setAttribute('data-sdkn', name);
   script.setAttribute('data-sdkv', version);
   script.setAttribute(
     'data-cookie-options',