Fix types and linting

dubinc · Feb 13, 2024 · 8f66d10 · 8f66d10
1 parent 30bb8b9
commit 8f66d10
Show file tree

Hide file tree

Showing 6 changed files with 209 additions and 22 deletions.
diff --git a/apps/nextjs/package.json b/apps/nextjs/package.json
@@ -5,7 +5,6 @@
   "scripts": {
     "build": "next build",
     "dev": "next dev",
-    "lint": "next lint",
     "start": "next start"
   },
   "dependencies": {
@@ -18,6 +17,7 @@
     "@types/node": "^20",
     "@types/react": "^18",
     "@types/react-dom": "^18",
+    "eslint-config-next": "14.1.0",
     "typescript": "^5"
   }
 }
diff --git a/packages/eslint-config/index.js b/packages/eslint-config/index.js
@@ -10,6 +10,9 @@ module.exports = {
   env: {
     jest: true,
   },
+  rules: {
+    'jest/no-deprecated-functions': 'off',
+  },
   parserOptions: {
     project: './tsconfig.json',
   },

diff --git a/packages/web/src/generic.ts b/packages/web/src/generic.ts
@@ -52,12 +52,13 @@ function track(
   if (!isBrowser()) {
     const msg =
       '[Dub Web Analytics] is currently only supported in the browser environment. The server tracking is coming soon.';
+    // eslint-disable-next-line no-console -- Logging to console is intentional
     console.warn(msg);
     return;
   }
 
   if (!properties) {
-    window.da?.track?.('event', { eventName });
+    window.da?.track('event', { eventName });
     return;
   }
 
@@ -66,11 +67,12 @@ function track(
       strip: true,
     });
 
-    window.da?.track?.('event', {
+    window.da?.track('event', {
       eventName,
       properties: cleanedProperties,
     });
   } catch (err) {
+    // eslint-disable-next-line no-console -- Logging to console is intentional
     console.error(err);
   }
 }

diff --git a/packages/web/src/types.ts b/packages/web/src/types.ts
@@ -4,9 +4,7 @@ export interface AnalyticsProps {
   apiKey?: string;
 }
 
-export type TrackEventProperties = {
-  [key: string]: AllowedPropertyValues;
-};
+export type TrackEventProperties = Record<string, AllowedPropertyValues>;
 
 export interface TrackFunction {
   (eventName: string, properties?: TrackEventProperties): void;

diff --git a/packages/web/src/utils.tsx b/packages/web/src/utils.tsx
@@ -20,7 +20,6 @@ export function parseProperties(
   if (!properties) return undefined;
   let props = properties;
   const errorProperties: string[] = [];
-  // @ts-ignore
   for (const [key, value] of Object.entries(properties)) {
     if (typeof value === 'object' && value !== null) {
       if (options.strip) {