Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header images and background colors. Fixes #52 #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented May 5, 2016

See my comment at
#52 (comment)
for implementation specific details

Header image or background color
--------------------------------

- ``header_cover`` - header background image. Configure as article metadata
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have listed the options in the same order of priority given in the code. Can you write just a line before to make it explicit in the doc?

Also, wouldn't it be better to actually give more priority to the article's properties instead of cover -> color? Something like:

  1. article's header_cover property
  2. article's header_color property
  3. global HEADER_COVER
  4. global HEADER_COLOR

@atodorov
Copy link
Contributor Author

ping, any updates here? This can still be merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants